Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove boost::lexical_cast #1205

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Remove boost::lexical_cast #1205

merged 2 commits into from
Sep 25, 2023

Conversation

WardBrian
Copy link
Member

Submisison Checklist

  • Run tests: ./runCmdStanTests.py src/test
  • Declare copyright holder and open-source license: see below

Summary:

Closes #1170.

Code is not necessarily the nicest. I used an out parameter so I could use the normal overload mechanism to keep the class generic

Intended Effect:

Remove deprecation warnings.

How to Verify:

Side Effects:

Documentation:

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Copy link
Member

@mitzimorris mitzimorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thannks for coding this up!

@mitzimorris mitzimorris merged commit 3e2190d into develop Sep 25, 2023
1 check passed
@WardBrian WardBrian deleted the cleanup/remove-lexical-cast branch September 27, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use C++ std::stoi et al instead of boost::lexical_cast
2 participants